Fix for ignored ssl_protocols and ssl_ciphers directive in conf.d/inc… #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lude/ssl-ciphers.conf
nginx only uses the `ssl_protocols` directive in the `server{}` block of the first processed host config, which is the default config in `/etc/nginx/conf.d/default.conf`. in version `v2.9.20` the default ssl site was dropped by using `ssl_reject_handshake on` in the default host config. but beside the include of `conf.d/include/ssl-ciphers.conf` was removed from the default host config. that's why `tlsv1.3` isn't applied by default anymore, same thing with the defined cipher suites. npm is so broken since `2023-03-16`.
commit that broke the config -> NginxProxyManager@a7f0c3b
This was referenced May 19, 2023
|
Docker Image for build 1 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
nietzscheanic
referenced
this pull request
May 20, 2023
Instead of creating a dummy certificate, we can return an SSL protocol error, which will generate a descriptive error message in the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lude/ssl-ciphers.conf
nginx only uses the
ssl_protocolsdirective in theserver{}block of the first processed host config, which is the default config in/etc/nginx/conf.d/default.conf. in versionv2.9.20the default ssl site was dropped by usingssl_reject_handshake onin the default host config. but beside the include ofconf.d/include/ssl-ciphers.confwas removed from the default host config. that's whytlsv1.3isn't applied by default anymore, same thing with the defined cipher suites. npm is so broken since2023-03-16.commit that broke the config -> a7f0c3b